-
Notifications
You must be signed in to change notification settings - Fork 4.1k
[Az.Resources] Add breaking change preannouncement for PSRoleDefinition type changes
#29068
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds breaking change preannouncements for PSRoleDefinition type restructuring in Az.Resources 10.0.0 (Az 16.0.0). The breaking change involves replacing flattened permission properties with a structured Permissions array.
Changes:
- Added
GenericBreakingChangeWithVersionattributes to four role definition cmdlets to notify users about upcoming type changes - Updated ChangeLog.md with detailed information about the breaking changes and affected cmdlets
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| GetAzureRoleDefinitionCommand.cs | Added breaking change attribute for output type changes |
| NewAzureRoleDefinitionCommand.cs | Added breaking change attribute for input format and output type changes |
| SetAzureRoleDefinitionCommand.cs | Added breaking change attribute for input format and output type changes |
| RemoveAzureRoleDefinitionCommand.cs | Added breaking change attribute for -InputObject parameter and -PassThru output changes |
| ChangeLog.md | Added entry documenting the breaking change preannouncement with affected cmdlets |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
33dbc22 to
e3d2075
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
vidai-msft
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Issue: #29058
PR with the breaking change: #29060
Description
This PR adds breaking change preannouncements for the
PSRoleDefinitiontype restructuring in Az.Resources 10.0.0 / Az 16.0.0.The breaking change involves:
Actions,NotActions,DataActions,NotDataActions,Condition,ConditionVersion) fromPSRoleDefinitionPermissionsarray containing permission objects with these propertiesAffected cmdlets:
Get-AzRoleDefinitionNew-AzRoleDefinition-InputFileJSON,-Roleparameter) and output type changeSet-AzRoleDefinition-InputFileJSON,-Roleparameter) and output type changeRemove-AzRoleDefinition-InputObjectparameter type and-PassThruoutput changeExample output
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense. ✅ChangeLog.mdif no new release is required, such as fixing test case only.